Fix fake_initialize_model_parallel for MoE models#11441
Closed
guyueh1 wants to merge 7 commits intoNVIDIA-NeMo:mainfrom
Closed
Fix fake_initialize_model_parallel for MoE models#11441guyueh1 wants to merge 7 commits intoNVIDIA-NeMo:mainfrom
guyueh1 wants to merge 7 commits intoNVIDIA-NeMo:mainfrom
Conversation
* Make the use of RankGenerator consistent with recent Mcore changes !1940 ( NVIDIA/Megatron-LM@7f22e21) - use ep=1 for decoder_rank_generator, making it treat EP as part of DP - define a new expert_decoder_rank_generator to handle EP groups/ranks only Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: guyueh1 <guyueh1@users.noreply.github.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Collaborator
Author
|
@akoumpa could you trigger CI |
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
…into fix_parallel_state_for_moe
Contributor
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
Collaborator
Author
|
Closing this since !11427 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Make the use of megatron RankGenerator consistent with recent megatron changes !1940
Collection: [Note which collection this PR will affect]
Changelog
Make the use of RankGenerator consistent with recent Mcore changes !1940
In
fake_initialize_model_parallelfunction innemo/collections/nlp/modules/common/megatron/megatron_init.pyUsage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information